fix ttl not work due to job not close tx by zhoney · Pull Request #1330 · apache/hugegraph
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 583
Merged
fix ttl not work due to job not close tx#1330
fix ttl not work due to job not close tx#1330
Conversation
Copy link
Contributor
zhoney
commented
Jan 12, 2021
zhoney
commented
Change-Id: Ic4a3bc11e67f92c88772149d5c304a2c1da0ec64
Change-Id: Ic4a3bc11e67f92c88772149d5c304a2c1da0ec64
Copy link
Codecov Report
Merging #1330 (4047231) into master (26ac664) will increase coverage by
0.43%.
The diff coverage is100.00%.
@@ Coverage Diff @@ ## master #1330 +/- ## ============================================ + Coverage 61.88% 62.32% +0.43% - Complexity 5751 5770 +19 ============================================ Files 377 377 Lines 31543 31553 +10 Branches 4419 4422 +3 ============================================ + Hits 19521 19666 +145 + Misses 10029 9887 -142 - Partials 1993 2000 +7
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 26ac664...4047231. Read the comment docs.
javeme requested changes Jan 12, 2021
| } | ||
|
|
||
| protected void closeTx() { | ||
| if (this.graph().tx().isOpen()) { |
Copy link
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
define tx first
javeme approved these changes Jan 13, 2021
Linary approved these changes Jan 13, 2021
Linary
merged commit
e0f36bd
into
master
Linary
deleted the
fix-gremlin-job-ttl
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants