refact: let kout degree applied to all labels & remove source vertex from kneighbor default results by imbajin · Pull Request #1459 · apache/hugegraph
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 583
Merged
refact: let kout degree applied to all labels & remove source vertex from kneighbor default results #1459
refact: let kout degree applied to all labels & remove source vertex from kneighbor default results #1459
Conversation
Copy link
Member
Contains 3 point:
- kout degree applied to all labels
- remove source vertex from default kneighbor result
- fix kneighbor result with limit may loss data because the duplicate elements of current layer are not excluded
PS: Also remove LimitIterator (moved to common) & add/adapt test for them on client#122
also remove LimitIterator (moved to common)
imbajin
requested review from
javeme and
zhoney
javeme reviewed May 19, 2021
hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/HugeTraverser.java
Outdated
Show resolved
Hide resolved
hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/HugeTraverser.java Outdated Show resolved Hide resolved
imbajin added 2 commits
May 19, 2021 21:01also need change relative test (carefully)
imbajin
changed the title
refactor: let kout degree applied to all labels
refact: let kout degree applied to all labels & remove source vertex from kneighbor default results
Copy link
Codecov Report
Merging #1459 (1a174db) into master (1ede97c) will increase coverage by
0.36%.
The diff coverage isn/a.
@@ Coverage Diff @@ ## master #1459 +/- ## ============================================ + Coverage 61.80% 62.17% +0.36% - Complexity 5840 5863 +23 ============================================ Files 381 381 Lines 32148 32177 +29 Branches 4504 4504 ============================================ + Hits 19869 20005 +136 + Misses 10231 10119 -112 - Partials 2048 2053 +5
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 1ede97c...1a174db. Read the comment docs.
zhoney previously approved these changes May 20, 2021
imbajin
dismissed
zhoney’s stale review
via
1a174db
zhoney approved these changes May 21, 2021
javeme approved these changes May 21, 2021
zhoney
merged commit
718daa6
into
master
zhoney
deleted the
fix-kout-degree
branch
zhoney pushed a commit that referenced this pull request
May 27, 2021…from kneighbor default results (#1459)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants