fix(core): traversal contains Tree step has different result in v0.12 by vincentshu · Pull Request #1755 · apache/hugegraph
…result comparing with [version 0.11.2]
fix #1745
…result comparing with [version 0.11.2] fix apache#1745
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! some minor comments~
| */ | ||
| protected static boolean containsTree(Traversal.Admin<?, ?> traversal) { | ||
| boolean hasPath = TraversalHelper.getStepsOfClass( | ||
| TreeStep.class, traversal).size() > 0; |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prefer to align with TraversalHelper
| * @return the traversal or its parents contain at least one Tree step | ||
| */ | ||
| protected static boolean containsTree(Traversal.Admin<?, ?> traversal) { | ||
| boolean hasPath = TraversalHelper.getStepsOfClass( |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we rename hasPath to hasTree?
imbajin
changed the title
Fix bug: [version 0.12.0] Traversal contains Tree step has different …
fix(core): traversal contains Tree step has different result in v0.12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters