improve the submission process of further changes by javeme · Pull Request #1757 · apache/hugegraph

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@javeme

Copy link

Contributor

@javeme javeme commented

Feb 15, 2022

No description provided.

@codecov

Copy link

codecov bot commented

Feb 15, 2022

edited

Loading

Codecov Report

Merging #1757 (8295ac2) into master (72baa12) will increase coverage by 0.40%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1757      +/-   ##
============================================
+ Coverage     70.35%   70.75%   +0.40%     
- Complexity      443      972     +529     
============================================
  Files           443      443              
  Lines         37729    37729              
  Branches       5378     5378              
============================================
+ Hits          26543    26697     +154     
+ Misses         8472     8311     -161     
- Partials       2714     2721       +7     
Impacted Files Coverage Δ
...om/baidu/hugegraph/task/StandardTaskScheduler.java 76.09% <0.00%> (-0.25%) ⬇️
.../baidu/hugegraph/backend/query/ConditionQuery.java 85.14% <0.00%> (+0.24%) ⬆️
.../backend/store/cassandra/CassandraSessionPool.java 57.14% <0.00%> (+1.02%) ⬆️
...egraph/backend/store/cassandra/CassandraShard.java 52.77% <0.00%> (+1.85%) ⬆️
...h/backend/store/scylladb/ScyllaDBTablesWithMV.java 96.03% <0.00%> (+96.03%) ⬆️
.../backend/store/scylladb/ScyllaDBStoreProvider.java 97.29% <0.00%> (+97.29%) ⬆️
...egraph/backend/store/scylladb/ScyllaDBMetrics.java 100.00% <0.00%> (+100.00%) ⬆️
...graph/backend/store/scylladb/ScyllaDBFeatures.java 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72baa12...8295ac2. Read the comment docs.

Copy link

Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: enhance the github-desktop priority & doc to avoid complex steps for normal contributors

@coderzc coderzc merged commit 88c7abd into master

Feb 21, 2022

@coderzc coderzc deleted the javeme-patch-1 branch

February 21, 2022 07:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@imbajin imbajin imbajin approved these changes

@coderzc coderzc coderzc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@javeme @imbajin @coderzc