fix edge batch update error by zhoney · Pull Request #1776 · apache/hugegraph
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 583
Merged
Conversation
Copy link
Contributor
zhoney
commented
Mar 9, 2022
zhoney
commented
Change-Id: I8742ca0e128e3c9bc3eb2ef99a52276045e17b79
Change-Id: I8742ca0e128e3c9bc3eb2ef99a52276045e17b79
Copy link
codecov
bot
commented
Mar 9, 2022
codecov bot commented
Mar 9, 2022Codecov Report
Merging #1776 (2d374e7) into master (730f332) will decrease coverage by
0.01%.
The diff coverage is0.00%.
@@ Coverage Diff @@ ## master #1776 +/- ## ============================================ - Coverage 66.85% 66.84% -0.02% + Complexity 972 970 -2 ============================================ Files 443 443 Lines 37738 37738 Branches 5381 5381 ============================================ - Hits 25229 25225 -4 - Misses 9788 9793 +5 + Partials 2721 2720 -1
| Impacted Files | Coverage Δ | |
|---|---|---|
| ...in/java/com/baidu/hugegraph/api/graph/EdgeAPI.java | 63.73% <0.00%> (ø) |
|
| ...in/java/com/baidu/hugegraph/backend/id/EdgeId.java | 75.89% <0.00%> (-1.79%) |
⬇️ |
| ...va/com/baidu/hugegraph/util/collection/IntSet.java | 73.61% <0.00%> (-1.28%) |
⬇️ |
| ...om/baidu/hugegraph/task/StandardTaskScheduler.java | 75.12% <0.00%> (-0.25%) |
⬇️ |
| ...du/hugegraph/backend/tx/GraphIndexTransaction.java | 83.61% <0.00%> (+0.10%) |
⬆️ |
| ...va/com/baidu/hugegraph/util/collection/IntMap.java | 72.00% <0.00%> (+0.40%) |
⬆️ |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 730f332...2d374e7. Read the comment docs.
javeme approved these changes Mar 9, 2022
imbajin approved these changes Mar 9, 2022
| HugeVertex.getIdValue(newEdge.target)); | ||
| if (newEdge.id != null) { | ||
| E.checkArgument(edgeId.equals(newEdge.id), | ||
| E.checkArgument(edgeId.asString().equals(newEdge.id), |
Copy link
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wonder in which case the edgeId can't compare with jsonEdgeId?
javeme
merged commit
6856cc2
into
master
javeme
deleted the
fix-edge-batch-update-error
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants