fix redundant Checkstyle by seagle-yuan · Pull Request #1896

fix redundant Checkstyle by seagle-yuan · Pull Request #1896 · apache/hugegraph

seagle-yuan changed the title ~~Checkstyle redundant~~ fix redundant Checkstyle

Jun 5, 2022

		@Override
		default User authenticate(final Map<String, String> credentials)
		throws AuthenticationException {
		throws AuthenticationException {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

align with final

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so we could algin with "final"
if we break line from "credentials",we can align with "final",because "final Map<String, String> credentials" are the entire content in parenthesis
but "throws" is out of parenthesis

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


		PathSet findPath(Id target, Function<Id, Boolean> filter,
		boolean all, boolean ring);
		PathSet findPath(Id target, Function<Id, Boolean> filter, boolean all,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prefer to wrap line before "boolean all"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line only 75 char. so i think wrap line after "boolean all" is better.

		*/
		default R scan(String table, byte[] startRow,
		boolean inclusiveStart, byte[] prefix) {
		default R scan(String table, byte[] startRow, boolean inclusiveStart,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prefer to wrap line before "boolean inclusiveStart"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line only 78 char.

		*/
		public abstract void put(String table, byte[] family,
		byte[] rowkey, byte[] qualifier, byte[] value);
		void put(String table, byte[] family, byte[] rowkey, byte[] qualifier,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prefer to wrap line before "byte[] qualifier"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line is only 79 char

		* Get a record by rowkey and qualifier from a table
		*/
		public R get(String table, byte[] family, byte[] rowkey,
		R get(String table, byte[] family, byte[] rowkey,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing updating

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

		*/
		public default void remove(String table, byte[] family,
		byte[] rowkey, byte[] qualifier) {
		default void remove(String table, byte[] family, byte[] rowkey,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prefer to wrap line before "byte[] rowkey"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line only 72 char


		private void checkBatchResults(Object[] results, List<Row> rows)
		throws Throwable {
		throws Throwable {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

		*/
		public class Session extends AbstractBackendSession
		implements HbaseSession<RowIterator> {
		implements HbaseSession<RowIterator> {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we keep the origin style: align 'implements' with 'extends'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

		public default User authenticate(final Map<String, String> credentials)
		throws AuthenticationException {
		default User authenticate(final Map<String, String> credentials)
		throws AuthenticationException {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we keep the origin style: align 'throws' with 'final'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

		// TODO: Mark and delete committed records
		throw new BackendException("Failed to commit, " +
		"there may be inconsistent states for HBase", e);
		"there may be inconsistent states for HBase", e);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exceed 100 chars?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

		byte[] val = CellUtil.cloneValue(cell);
		LOG.info(" {}={}", StringEncoding.format(key),
		StringEncoding.format(val));
		StringEncoding.format(val));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also wrap line before StringEncoding.format(key) for logic symmetry

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

		</module>
		<module name="OneStatementPerLine"/>
		<module name="MultipleVariableDeclarations"/>
		<module name="MissingSwitchDefault"/>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why removed MissingSwitchDefault check


		private void checkBatchResults(Object[] results, List<Row> rows)
		throws Throwable {
		throws Throwable {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we keep the origin style: align 'throws' with 'Object[]'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label

javeme left a comment •

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

javeme left a comment • Loading

Choose a reason for hiding this comment

javeme left a comment •

Loading