chore: bump Dockerfile SERVER_VERSION to 0.12.0 by simon824 · Pull Request #1901 · apache/hugegraph

@simon824

@simon824

@codecov

@simon824

javeme

@simon824

@simon824 simon824 changed the title chore: update PKG_URL and SERVER_VERSION for Dockerfile chore: bump Dockerfile SERVER_VERSION to 0.12.0

Jun 13, 2022

@imbajin

Thanks, a few questions:

  1. After the upgrade, do we test server initialization and startup OK?
  2. Could studio connect to server 0.12? (shall we upgrade the version or use hubble instead?)

Links the TODO issue, and we need upload the image to Dockerhub

@imbajin imbajin linked an issue

Jun 13, 2022

that may be closed by this pull request

17 tasks

imbajin

Comment on lines +30 to +31

&& sed -n '65p' ./bin/start-hugegraph.sh | grep "&" > /dev/null && sed -i 65{s/\&$/#/g} ./bin/start-hugegraph.sh \
&& sed -n '75p' ./bin/start-hugegraph.sh | grep "exit" > /dev/null && sed -i 75{s/^/#/g} ./bin/start-hugegraph.sh \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: we could add a option -f to run foreground (to avoid modify shell)

@simon824

Thanks, a few questions:

  1. After the upgrade, do we test server initialization and startup OK?
  2. Could studio connect to server 0.12? (shall we upgrade the version or use hubble instead?)

Links the TODO issue, and we need upload the image to Dockerhub

Maybe we can remove studio here and add another separate dockerfile for hubble ? WDYT @javeme @imbajin

@simon824

@imbajin

BTW, i find apache has it's own docker repository hub.docker.com/u/apache, do we need move hub.docker.com/u/hugegraph to apache's ?

fine if it's easy to move

Maybe we can remove studio here and add another separate dockerfile for hubble

we could remove studio in dockerfile after we add a separate one for hubble

javeme

imbajin

@imbajin imbajin changed the title chore: bump Dockerfile SERVER_VERSION to 0.12.0 chore: bump Dockerfile SERVER_VERSION to 0.12.0

Jun 25, 2022