Adding try-with-resources block around PredictionTraverser by vamossagar12 · Pull Request #2016 · apache/hugegraph

@vamossagar12

@vamossagar12

@javeme , another small PR. Plz review. Thanks!

@codecov

Codecov Report

Merging #2016 (833ce2f) into master (833ce2f) will not change coverage.
The diff coverage is n/a.

❗ Current head 833ce2f differs from pull request most recent head 895f249. Consider uploading reports for the commit 895f249 to get more accurate results

@@            Coverage Diff            @@
##             master    #2016   +/-   ##
=========================================
  Coverage     66.34%   66.34%           
  Complexity      978      978           
=========================================
  Files           482      482           
  Lines         41457    41457           
  Branches       5890     5890           
=========================================
  Hits          27506    27506           
  Misses        11251    11251           
  Partials       2700     2700           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

javeme

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution~

imbajin

javeme

Sagar Rao added 2 commits

November 14, 2022 23:07

@javeme

I've updated the branch on the github page that caused the author is changed, which doesn't seem to be expected behavior.
rebase-update

@vamossagar12 can you please rebase on the latest master by git rebase -i master and git push -f again?

@imbajin

I've updated the branch on the github page that caused the author is changed, which doesn't seem to be expected behavior.
rebase-update

@vamossagar12 can you please rebase on the latest master by git rebase -i master and git push -f again?

could just use merge from master option(rather than rebase from master),merge it wont break the code commit/review

@javeme

It looks ok and doesn't change the actual author:
ahthor-ok

@vamossagar12