[fix][cli] Fix start cli error by coderzc · Pull Request #2024 · apache/hugegraph

[fix][cli] Fix start cli error by coderzc · Pull Request #2024 · apache/hugegraph

Motivation

Run bin/hugegraph start error

Starting HugeGraphServer...
bin/hugegraph: line 68: /start-hugegraph.sh: No such file or directory
Failed to start service

Modifications

Add check for Variables

coderzc changed the title ~~[Fix] Fix start shell error~~ [fix][cli] Fix start shell error

coderzc changed the title ~~[fix][cli] Fix start shell error~~ [fix][cli] Fix start cli error

zyxxoo previously approved these changes Nov 20, 2022

Comment on lines 39 to -40

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change the comment, it requires user to set a fixed abs path manually (should't use a relative path)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. and I think should add check for Variables

		### END INIT INFO

		# Variables
		# it requires user to set a fixed abs path manually

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

		INSTALL_DIR=
		SERVER_PORT=

		${INSTALL_DIR:?"Please setting variables 'INSTALL_DIR'"}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😺, nice

typo `setting --> set``

javeme previously approved these changes Nov 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll enhance this script later

javeme deleted the fix_start_shell branch

November 22, 2022 12:56

imbajin pushed a commit to z7658329/hugegraph that referenced this pull request