fix(test): exclude binary file in clean plugin by zyxxoo · Pull Request #2052 · apache/hugegraph
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 583
Conversation
Copy link
Codecov Report
Merging #2052 (162693a) into master (9cbb618) will increase coverage by
0.00%.
The diff coverage isn/a.
@@ Coverage Diff @@ ## master #2052 +/- ## ========================================= Coverage 68.41% 68.41% - Complexity 976 978 +2 ========================================= Files 481 481 Lines 39749 39749 Branches 5582 5582 ========================================= + Hits 27193 27195 +2 + Misses 9929 9926 -3 - Partials 2627 2628 +1
| Impacted Files | Coverage Δ | |
|---|---|---|
| ...hugegraph/backend/store/raft/rpc/RpcForwarder.java | 69.49% <0.00%> (-1.70%) |
⬇️ |
| ...a/org/apache/hugegraph/task/ServerInfoManager.java | 75.00% <0.00%> (+1.74%) |
⬆️ |
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more
zyxxoo
requested review from
imbajin and
javeme
imbajin approved these changes Dec 15, 2022
Copy link
Member
imbajin
left a comment
imbajin
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: move binary to target/ later & improve the plugin settings (current is misunderstand)
imbajin reviewed Dec 15, 2022
| <excludes> | ||
| <exclude>${final.name}/**</exclude> | ||
| <exclude>*.tar.gz</exclude> | ||
| <exclude>*.zip</exclude> |
Copy link
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems no need for zip? (update it in future)
imbajin
changed the title
fix: keep binary file
fix(test): exclude binary file in clean plugin
Linary approved these changes Dec 15, 2022
zyxxoo
merged commit
85499f3
into
master
zyxxoo
deleted the
zy_dev
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment