refact(core): early stop unnecessary loops in edge cache by GYXkeep · Pull Request #2211 · apache/hugegraph
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 583
Merged
imbajin merged 1 commit intoapache:masterfrom
May 16, 2023Merged
refact(core): early stop unnecessary loops in edge cache#2211
imbajin merged 1 commit intoapache:masterfrom
refact(core): early stop unnecessary loops in edge cache#2211
imbajin merged 1 commit intoapache:masterfrom
Conversation
Copy link
Contributor
GYXkeep
commented
May 16, 2023
GYXkeep
commented
The loop in this method can jump out directly when the condition is met, avoiding useless loops.
Copy link
Codecov Report
Merging #2211 (cbb7dd2) into master (267ff6d) will increase coverage by
3.55%.
The diff coverage is100.00%.
@@ Coverage Diff @@ ## master #2211 +/- ## ============================================ + Coverage 61.53% 65.08% +3.55% - Complexity 484 979 +495 ============================================ Files 497 497 Lines 40572 40573 +1 Branches 5663 5663 ============================================ + Hits 24965 26406 +1441 + Misses 13061 11553 -1508 - Partials 2546 2614 +68
| Impacted Files | Coverage Δ | |
|---|---|---|
| ...ugegraph/backend/cache/CachedGraphTransaction.java | 80.52% <100.00%> (+0.10%) |
⬆️ |
... and 27 files with indirect coverage changes
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more
javeme approved these changes May 16, 2023
Copy link
Contributor
javeme
left a comment
javeme
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
imbajin
changed the title
break out of unnecessary loops
refact(core): break out of unnecessary loops in edge cache
imbajin
changed the title
refact(core): break out of unnecessary loops in edge cache
refact(core): early stop unnecessary loops in edge cache
imbajin approved these changes May 16, 2023
Copy link
Member
Also mark the rocksdb raft test as a TODO problem, add it to the "help wanted tasks"
imbajin
merged commit
f23c648
into
apache:master
Copy link
Member
imbajin
commented
May 16, 2023
imbajin commented
May 16, 2023TODO: Also another CI problem need to fix, refer link
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants