Home Original page

fix: jdbc ssl mode parameter redundant by liuxiaocs7 · Pull Request #2224 · apache/hugegraph

Conversation

@liuxiaocs7 liuxiaocs7 changed the title fix: jdbc ssl mode parameter fix: jdbc ssl mode parameter redundant

Jun 5, 2023

@codecov

Codecov Report

Merging #2224 (6a2b24f) into master (bcf2a39) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2224   +/-   ##
=========================================
  Coverage     65.03%   65.04%           
  Complexity      977      977           
=========================================
  Files           498      498           
  Lines         40681    40681           
  Branches       5681     5681           
=========================================
+ Hits          26457    26461    +4     
+ Misses        11597    11592    -5     
- Partials       2627     2628    +1

see 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

imbajin

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, and check if the log print as expected after we rename the config

@liuxiaocs7

Good, and check if the log print as expected after we rename the config

conf:

backend=mysql
serializer=mysql

# mysql backend config
jdbc.driver=com.mysql.cj.jdbc.Driver
jdbc.url=jdbc:mysql://127.0.0.1:3306
jdbc.username=root
jdbc.password=xxxxxx
jdbc.reconnect_max_times=3
jdbc.reconnect_interval=3
jdbc.ssl_mode=false

logs:

2023-06-06 14:26:04 [main] [INFO] o.a.h.u.ConfigUtil - Scanning option 'graphs' directory './conf/graphs'
2023-06-06 14:26:04 [main] [INFO] o.a.h.c.InitStore - Init graph with config file: .\conf\graphs\hugegraph.properties
2023-06-06 14:26:04 [main] [INFO] o.a.h.b.s.m.MysqlSessions - Connect to the jdbc url: 'jdbc:mysql://127.0.0.1:3306/?socketTimeout=0&useSSL=false'
2023-06-06 14:26:04 [main] [INFO] o.a.h.b.s.m.MysqlStore - Failed to open database 'hugegraph', try to init database later
2023-06-06 14:26:04 [main] [INFO] o.a.h.b.c.CacheManager - Init RamCache for 'schema-id-hugegraph' with capacity 10000
2023-06-06 14:26:04 [main] [INFO] o.a.h.b.c.CacheManager - Init RamCache for 'schema-name-hugegraph' with capacity 10000
2023-06-06 14:26:04 [main] [INFO] o.a.h.b.s.m.MysqlSessions - Connect to the jdbc url: 'jdbc:mysql://127.0.0.1:3306/?socketTimeout=0&useSSL=false'
main dict load finished, time elapsed 421 ms
model load finished, time elapsed 21 ms.

javeme