doc: enhance NOTICE info to keep it clear by imbajin · Pull Request #2409 · apache/hugegraph

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@imbajin

Copy link

Member

@imbajin imbajin commented

Jan 5, 2024

Purpose of the PR

Main Changes

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@dosubot dosubot bot added size:L

This PR changes 100-499 lines, ignoring generated files.

ci-cd

Build or deploy

labels

Jan 5, 2024

@codecov

Copy link

codecov bot commented

Jan 5, 2024

edited

Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7965aac) 66.23% compared to head (1bed696) 66.19%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2409      +/-   ##
============================================
- Coverage     66.23%   66.19%   -0.04%     
+ Complexity      830      828       -2     
============================================
  Files           511      511              
  Lines         42595    42595              
  Branches       5942     5942              
============================================
- Hits          28211    28197      -14     
- Misses        11568    11584      +16     
+ Partials       2816     2814       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Member

@simon824 simon824 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm

This PR has been approved by a maintainer

label

Jan 8, 2024

@imbajin imbajin merged commit 57cd0e8 into master

Jan 9, 2024

@imbajin imbajin deleted the notice branch

January 9, 2024 10:44

VGalaxies pushed a commit to VGalaxies/incubator-hugegraph that referenced this pull request

Jan 12, 2024

Z-HUANT pushed a commit to Z-HUANT/incubator-hugegraph that referenced this pull request

Jan 23, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JackyYangPassion JackyYangPassion JackyYangPassion approved these changes

@simon824 simon824 simon824 approved these changes

Assignees

No one assigned

Labels

ci-cd

Build or deploy

lgtm

This PR has been approved by a maintainer

size:L

This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@imbajin @JackyYangPassion @simon824