doc: enhance NOTICE info to keep it clear by imbajin · Pull Request #2409 · apache/hugegraph
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 583
Conversation
Copy link
Member
imbajin
commented
Jan 5, 2024
imbajin
commented
Purpose of the PR
Main Changes
Verifying these changes
- Trivial rework / code cleanup without any test coverage. (No Need)
- Already covered by existing tests, such as (please modify tests here).
- Need tests and can be verified as follows:
- xxx
Does this PR potentially affect the following parts?
- Nope
- Dependencies (add/update license info)
- Modify configurations
- The public API
- Other affects (typed here)
Documentation Status
-
Doc - TODO -
Doc - Done -
Doc - No Need
imbajin
requested review from
JackyYangPassion and
simon824
labels
Jan 5, 2024Copy link
Codecov Report
All modified and coverable lines are covered by tests ✅
Comparison is base (
7965aac) 66.23% compared to head (1bed696) 66.19%.
Additional details and impacted files
@@ Coverage Diff @@ ## master #2409 +/- ## ============================================ - Coverage 66.23% 66.19% -0.04% + Complexity 830 828 -2 ============================================ Files 511 511 Lines 42595 42595 Branches 5942 5942 ============================================ - Hits 28211 28197 -14 - Misses 11568 11584 +16 + Partials 2816 2814 -2
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
imbajin
force-pushed
the
notice
branch
from
f85d29e to
1bed696
Compare
simon824 approved these changes Jan 8, 2024
Copy link
Member
simon824
left a comment
simon824
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
JackyYangPassion approved these changes Jan 9, 2024
imbajin
merged commit
57cd0e8
into
master
imbajin
deleted the
notice
branch
VGalaxies pushed a commit to VGalaxies/incubator-hugegraph that referenced this pull request
Jan 12, 2024Z-HUANT pushed a commit to Z-HUANT/incubator-hugegraph that referenced this pull request
Jan 23, 2024This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment