chore(docker): cherry-pick commits from master for fix some error when using docker image for 1.2.0 as #2403 by aroundabout · Pull Request #2417 · apache/hugegraph
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 583
Merged
imbajin merged 1 commit intoapache:docker-1.2.0from
Jan 17, 2024Conversation
Copy link
Contributor
aroundabout
commented
Jan 16, 2024
aroundabout
commented
Purpose of the PR
Main Changes
Verifying these changes
- Trivial rework / code cleanup without any test coverage. (No Need)
- Already covered by existing tests, such as (please modify tests here).
- Need tests and can be verified as follows:
- xxx
Does this PR potentially affect the following parts?
- Nope
- Dependencies (add/update license info)
- Modify configurations
- The public API
- Other affects (typed here)
Documentation Status
-
Doc - TODO -
Doc - Done -
Doc - No Need
- allow user to set env for docker to set auth mode - download keystore when package - fix a curl error (also use curl first in `function` download) --------- Co-authored-by: imbajin <jin@apache.org>
labels
Jan 16, 2024
Copy link
Codecov Report
All modified and coverable lines are covered by tests ✅
Comparison is base (
7635c67) 65.59% compared to head (626b46d) 66.14%.
Additional details and impacted files
@@ Coverage Diff @@ ## docker-1.2.0 #2417 +/- ## ================================================== + Coverage 65.59% 66.14% +0.54% - Complexity 587 828 +241 ================================================== Files 511 511 Lines 42590 42590 Branches 5941 5941 ================================================== + Hits 27936 28170 +234 + Misses 11840 11605 -235 - Partials 2814 2815 +1
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
imbajin approved these changes Jan 17, 2024
imbajin
merged commit
1123e85
into
apache:docker-1.2.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment