fix(server): make CacheManager constructor private to satisfy the singleton pattern by Pengzna · Pull Request #2432 · apache/hugegraph
For the sake of regulation and safety, we should privatize the constructor of cacheManager to satisfy the singleton pattern
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch~
Codecov Report
All modified and coverable lines are covered by tests ✅
Comparison is base (
1d4532c) 66.23% compared to head (3b2f5a9) 66.20%.
Additional details and impacted files
@@ Coverage Diff @@ ## master #2432 +/- ## ============================================ - Coverage 66.23% 66.20% -0.04% Complexity 828 828 ============================================ Files 511 511 Lines 42597 42597 Branches 5942 5942 ============================================ - Hits 28215 28202 -13 - Misses 11566 11584 +18 + Partials 2816 2811 -5
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
This comment was marked as off-topic.
This comment was marked as off-topic.
imbajin
changed the title
fix: privatize the constructor of cacheManager to satisfy the singleton pattern
fix(server): make CacheManager constructor private to satisfy the singleton pattern
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters