feat(store): integrate `store-core` submodule by Pengzna · Pull Request #2548 · apache/hugegraph

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@Pengzna

Copy link

Contributor

@Pengzna Pengzna commented

Jun 3, 2024

Subtask of #2265 and #2482

The corresponding tests will be merged after store-node

Detailed doc can be seen in this link

VGalaxies reacted with heart emoji JackyYangPassion reacted with rocket emoji

@dosubot dosubot bot added size:XXL

This PR changes 1000+ lines, ignoring generated files.

store

Store module

labels

Jun 3, 2024

@Pengzna

Copy link

Contributor Author

Pengzna commented

Jun 3, 2024

sheli00 reacted with thumbs up emoji

@codecov

Copy link

codecov bot commented

Jun 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 41.87%. Comparing base (b056c5f) to head (f87ae35).

Files Patch % Lines
...hugegraph/backend/serializer/BinarySerializer.java 0.00% 16 Missing ⚠️
...e/hugegraph/backend/serializer/TextSerializer.java 0.00% 2 Missing ⚠️
...gegraph/backend/serializer/AbstractSerializer.java 0.00% 1 Missing ⚠️
...ache/hugegraph/backend/serializer/BytesBuffer.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             master    #2548       +/-   ##
=============================================
- Coverage     56.95%   41.87%   -15.08%     
+ Complexity      827      656      -171     
=============================================
  Files           612      612               
  Lines         49652    49672       +20     
  Branches       6675     6681        +6     
=============================================
- Hits          28279    20801     -7478     
- Misses        18558    26657     +8099     
+ Partials       2815     2214      -601     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge it first

@dosubot dosubot bot added the lgtm

This PR has been approved by a maintainer

label

Jun 6, 2024

@JackyYangPassion JackyYangPassion merged commit ac93dee into apache:master

Jun 7, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JackyYangPassion JackyYangPassion JackyYangPassion approved these changes

@imbajin imbajin imbajin approved these changes

@VGalaxies VGalaxies VGalaxies approved these changes

+1 more reviewer

@sheli00 sheli00 sheli00 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm

This PR has been approved by a maintainer

size:XXL

This PR changes 1000+ lines, ignoring generated files.

store

Store module

Projects

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Pengzna @JackyYangPassion @imbajin @sheli00 @VGalaxies