chore: reset license header for file declared in LICENSE by VGalaxies · Pull Request #2550 · apache/hugegraph
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 583
Merged
chore: reset license header for file declared in LICENSE#2550
JackyYangPassion merged 1 commit intomasterfrom
chore: reset license header for file declared in LICENSE#2550
JackyYangPassion merged 1 commit intomasterfrom
Conversation
Copy link
Contributor
VGalaxies
commented
Jun 4, 2024
VGalaxies
commented
I notice that https://github.com/apache/incubator-hugegraph/blob/master/LICENSE#L210, the license header of StructureBasicSuite.java should be the same as ProcessBasicSuite.java?
VGalaxies
requested a review
from imbajin
label
Jun 4, 2024
VGalaxies
self-assigned this
Copy link
Contributor Author
VGalaxies
commented
Jun 4, 2024
VGalaxies commented
Jun 4, 2024@msgui could take a look here~
Copy link
Codecov Report
All modified and coverable lines are covered by tests ✅
Project coverage is 57.00%. Comparing base (
b056c5f) to head (76fc015).
Additional details and impacted files
@@ Coverage Diff @@ ## master #2550 +/- ## ============================================ + Coverage 56.95% 57.00% +0.04% - Complexity 827 829 +2 ============================================ Files 612 612 Lines 49652 49652 Branches 6675 6675 ============================================ + Hits 28279 28302 +23 + Misses 18558 18542 -16 + Partials 2815 2808 -7
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
imbajin approved these changes Jun 5, 2024
Copy link
Member
imbajin
left a comment
imbajin
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, maybe we need also search some keyword like @author * or mail format to check the source code reference
imbajin
added this to the
1.5.0 milestone
Copy link
Contributor Author
VGalaxies
commented
Jun 7, 2024
VGalaxies commented
Jun 7, 2024Yes, maybe we need also search some keyword like
@author *or
checked and found no omissions
imbajin
requested review from
JackyYangPassion and
liuxiaocs7
JackyYangPassion approved these changes Jun 11, 2024
JackyYangPassion
merged commit
506850c
into
master
JackyYangPassion
deleted the
fix-license
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment