fix(server): random generate default value by HJ-Young · Pull Request #2568 · apache/hugegraph
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 583
Merged
fix(server): random generate default value#2568
VGalaxies merged 4 commits intoapache:masterfrom
fix(server): random generate default value#2568
VGalaxies merged 4 commits intoapache:masterfrom
Conversation
Copy link
Contributor
HJ-Young
commented
Jul 2, 2024
HJ-Young
commented
Purpose of the PR
- close #xxx
Main Changes
Verifying these changes
- Trivial rework / code cleanup without any test coverage. (No Need)
- Already covered by existing tests, such as AuthTest.
- Need tests and can be verified as follows:
- xxx
Does this PR potentially affect the following parts?
- Dependencies (add/update license info & regenerate_dependencies)
- Modify configurations
- The public API
- Other affects (typed here)
- Nope
Documentation Status
-
Doc - TODO -
Doc - Done -
Doc - No Need
label
Jul 2, 2024
HJ-Young
changed the title
fix(server): Random generate default jwt secret key
fix(server): random generate default jwt secret key
HJ-Young added 2 commits
July 5, 2024 15:16
imbajin
requested review from
imbajin and
javeme
imbajin
added this to the
1.5.0 milestone
HJ-Young
changed the title
fix(server): random generate default jwt secret key
fix(server): random generate default value
imbajin reviewed Jul 13, 2024
hugegraph-server/hugegraph-core/src/main/java/org/apache/hugegraph/config/AuthOptions.java
Outdated
Show resolved
Hide resolved
hugegraph-server/hugegraph-core/src/main/java/org/apache/hugegraph/config/AuthOptions.java Outdated Show resolved Hide resolved
...graph-server/hugegraph-core/src/main/java/org/apache/hugegraph/auth/StandardAuthManager.java
Outdated
Show resolved
Hide resolved
...graph-server/hugegraph-core/src/main/java/org/apache/hugegraph/auth/StandardAuthManager.java Outdated Show resolved Hide resolved
imbajin approved these changes Jul 13, 2024
Copy link
Member
imbajin
left a comment
imbajin
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution~
Copy link
codecov
bot
commented
Jul 13, 2024
codecov bot commented
Jul 13, 2024Codecov Report
Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
Project coverage is 4.56%. Comparing base (
37e71c4) to head (85c2b6d).
Report is 2 commits behind head on master.
| Files | Patch % | Lines |
|---|---|---|
| .../java/org/apache/hugegraph/config/AuthOptions.java | 0.00% | 5 Missing ⚠️ |
| ...org/apache/hugegraph/auth/StandardAuthManager.java | 0.00% | 1 Missing ⚠️ |
❗ There is a different number of reports uploaded between BASE (37e71c4) and HEAD (85c2b6d). Click for more details.
Additional details and impacted files
@@ Coverage Diff @@ ## master #2568 +/- ## ============================================ - Coverage 56.42% 4.56% -51.87% + Complexity 586 479 -107 ============================================ Files 612 621 +9 Lines 49672 50875 +1203 Branches 6681 6570 -111 ============================================ - Hits 28029 2321 -25708 - Misses 18833 48367 +29534 + Partials 2810 187 -2623
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
VGalaxies approved these changes Jul 14, 2024
VGalaxies
merged commit
03b40a5
into
apache:master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment