fix(hstore): enable JRaft MaxBodySize config by JackyYangPassion · Pull Request #2633 · apache/hugegraph

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@JackyYangPassion

Copy link

Contributor

Purpose of the PR

Main Changes

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@dosubot dosubot bot added size:XS

This PR changes 0-9 lines, ignoring generated files.

raft store

Store module

labels

Aug 12, 2024

javeme

javeme previously approved these changes Aug 17, 2024

@dosubot dosubot bot added the lgtm

This PR has been approved by a maintainer

label

Aug 17, 2024

VGalaxies

VGalaxies previously approved these changes Aug 17, 2024

Caused by: org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'org.apache.hugegraph.store.node.AppConfig$Raft': Unsatisfied dependency expressed through field 'maxBodySize'; nested exception is org.springframework.beans.TypeMismatchException: Failed to convert value of type 'java.lang.String' to required type 'int'; nested exception is java.lang.NumberFormatException: For input string: "512*1024"

@VGalaxies VGalaxies dismissed stale reviews from javeme and themself via 1c12163

August 18, 2024 03:56

@dosubot dosubot bot added size:S

This PR changes 10-29 lines, ignoring generated files.

and removed size:XS

This PR changes 0-9 lines, ignoring generated files.

labels

Aug 18, 2024

@imbajin imbajin merged commit 58f58ee into apache:master

Aug 18, 2024

@codecov

Copy link

codecov bot commented

Aug 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 1.21%. Comparing base (ba5b89e) to head (1c12163).
Report is 1 commits behind head on master.

Files Patch % Lines
...va/org/apache/hugegraph/store/PartitionEngine.java 0.00% 1 Missing ⚠️
.../hugegraph/store/options/HgStoreEngineOptions.java 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (ba5b89e) and HEAD (1c12163). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (ba5b89e) HEAD (1c12163)
5 1
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #2633       +/-   ##
============================================
- Coverage     46.84%   1.21%   -45.63%     
+ Complexity      343       8      -335     
============================================
  Files           719     697       -22     
  Lines         58465   55952     -2513     
  Branches       7495    7047      -448     
============================================
- Hits          27387     682    -26705     
- Misses        28306   55219    +26913     
+ Partials       2772      51     -2721     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@imbajin imbajin imbajin approved these changes

@VGalaxies VGalaxies VGalaxies approved these changes

@javeme javeme javeme left review comments

Assignees

No one assigned

Labels

lgtm

This PR has been approved by a maintainer

raft size:S

This PR changes 10-29 lines, ignoring generated files.

store

Store module

Projects

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature] HStore Add JRaft maxBodySize configuration parameters

4 participants

@JackyYangPassion @javeme @imbajin @VGalaxies