fix(hstore): enable JRaft MaxBodySize config by JackyYangPassion · Pull Request #2633 · apache/hugegraph
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 583
Merged
imbajin merged 3 commits intoapache:masterfrom
Aug 18, 2024Merged
fix(hstore): enable JRaft MaxBodySize config#2633
imbajin merged 3 commits intoapache:masterfrom
fix(hstore): enable JRaft MaxBodySize config#2633
imbajin merged 3 commits intoapache:masterfrom
Conversation
Copy link
Contributor
JackyYangPassion
commented
Aug 12, 2024
JackyYangPassion
commented
Purpose of the PR
Main Changes
Verifying these changes
- Trivial rework / code cleanup without any test coverage. (No Need)
- Already covered by existing tests, such as (please modify tests here).
- Need tests and can be verified as follows:
- xxx
Does this PR potentially affect the following parts?
- Dependencies (add/update license info & regenerate_dependencies)
- Modify configurations
- The public API
- Other affects (typed here)
- Nope
Documentation Status
-
Doc - TODO -
Doc - Done -
Doc - No Need
labels
Aug 12, 2024javeme previously approved these changes Aug 17, 2024
VGalaxies previously approved these changes Aug 17, 2024
VGalaxies added 2 commits
August 18, 2024 10:59Caused by: org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'org.apache.hugegraph.store.node.AppConfig$Raft': Unsatisfied dependency expressed through field 'maxBodySize'; nested exception is org.springframework.beans.TypeMismatchException: Failed to convert value of type 'java.lang.String' to required type 'int'; nested exception is java.lang.NumberFormatException: For input string: "512*1024"
VGalaxies
dismissed stale reviews from javeme and themself
via
1c12163
and removed size:XS
This PR changes 0-9 lines, ignoring generated files.labels
Aug 18, 2024VGalaxies approved these changes Aug 18, 2024
imbajin approved these changes Aug 18, 2024
imbajin
merged commit
58f58ee
into
apache:master
Copy link
codecov
bot
commented
Aug 18, 2024
codecov bot commented
Aug 18, 2024Codecov Report
Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
Project coverage is 1.21%. Comparing base (
ba5b89e) to head (1c12163).
Report is 1 commits behind head on master.
| Files | Patch % | Lines |
|---|---|---|
| ...va/org/apache/hugegraph/store/PartitionEngine.java | 0.00% | 1 Missing ⚠️ |
| .../hugegraph/store/options/HgStoreEngineOptions.java | 0.00% | 1 Missing ⚠️ |
❗ There is a different number of reports uploaded between BASE (ba5b89e) and HEAD (1c12163). Click for more details.
Additional details and impacted files
@@ Coverage Diff @@ ## master #2633 +/- ## ============================================ - Coverage 46.84% 1.21% -45.63% + Complexity 343 8 -335 ============================================ Files 719 697 -22 Lines 58465 55952 -2513 Branches 7495 7047 -448 ============================================ - Hits 27387 682 -26705 - Misses 28306 55219 +26913 + Partials 2772 51 -2721
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment