chore(dist): intro additional Dockerfile to build the server image & skip init-hstore backend by VGalaxies · Pull Request #2642 · apache/hugegraph

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@VGalaxies

Copy link

Contributor

For the compatibility of https://hub.docker.com/r/hugegraph/hugegraph image, the default backend of hugegraph.properties is still configured as rocksdb; the backend of https://hub.docker.com/r/hugegraph/server image defaults to hstore.

@VGalaxies VGalaxies requested a review from imbajin

August 16, 2024 12:51

@dosubot dosubot bot added size:L

This PR changes 100-499 lines, ignoring generated files.

ci-cd

Build or deploy

feature

New feature

labels

Aug 16, 2024

@codecov

Copy link

codecov bot commented

Aug 16, 2024

edited

Loading

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 47.13%. Comparing base (1c577de) to head (b8929e0).
Report is 3 commits behind head on master.

Files Patch % Lines
.../main/java/org/apache/hugegraph/cmd/InitStore.java 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2642      +/-   ##
============================================
+ Coverage     45.35%   47.13%   +1.78%     
- Complexity      496      583      +87     
============================================
  Files           719      719              
  Lines         58465    58469       +4     
  Branches       7495     7496       +1     
============================================
+ Hits          26514    27558    +1044     
+ Misses        29230    28132    -1098     
- Partials       2721     2779      +58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dosubot dosubot bot added the lgtm

This PR has been approved by a maintainer

label

Aug 17, 2024

@imbajin imbajin merged commit 7dc6a86 into master

Aug 22, 2024

@imbajin imbajin changed the title chore(dist): intro additional Dockerfile to build the server image & skip initializing hstore backend chore(dist): intro additional Dockerfile to build the server image & skip init-hstore backend

Aug 22, 2024

@imbajin imbajin deleted the fix-docker branch

August 22, 2024 06:04

imbajin pushed a commit to hugegraph/actions that referenced this pull request

Aug 22, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@imbajin imbajin imbajin approved these changes

@coderzc coderzc coderzc approved these changes

@JackyYangPassion JackyYangPassion Awaiting requested review from JackyYangPassion

Assignees

No one assigned

Labels

ci-cd

Build or deploy

feature

New feature

lgtm

This PR has been approved by a maintainer

size:L

This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@VGalaxies @imbajin @coderzc