chore(server): mark old raft configs as deprecated by shirleyStorage · Pull Request #2661 · apache/hugegraph

Conversation

@shirleyStorage

Purpose of the PR

Main Changes

Place the raft configurations at the bottom of the properties file and mark it as being deprecated.

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need
Signed-off-by: shirley <shirley.d.storage@gmail.com>

@dosubot dosubot bot added size:M

This PR changes 30-99 lines, ignoring generated files.

raft labels

Sep 4, 2024

@shirleyStorage

@imbajin PTAL~
This PR is related to "Mark raft-mode configs as legacy (put them on the bottom - properties)" of #2575

@codecov

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.42%. Comparing base (a529c02) to head (84b3caf).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (a529c02) and HEAD (84b3caf). Click for more details.

HEAD has 5 uploads less than BASE
Flag BASE (a529c02) HEAD (84b3caf)
7 2
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2661      +/-   ##
============================================
- Coverage     47.60%   38.42%   -9.19%     
+ Complexity      820      632     -188     
============================================
  Files           718      718              
  Lines         58469    58469              
  Branches       7496     7496              
============================================
- Hits          27835    22467    -5368     
- Misses        27854    33596    +5742     
+ Partials       2780     2406     -374     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

imbajin

imbajin

imbajin

@imbajin imbajin changed the title Note the old raft config will be deprecated chore(server): mark old raft configs as deprecated

Sep 6, 2024
Signed-off-by: shirley <shirley.d.storage@gmail.com>

VGalaxies

@dosubot dosubot bot added the lgtm

This PR has been approved by a maintainer

label

Sep 8, 2024

imbajin

Labels

lgtm

This PR has been approved by a maintainer

raft size:M

This PR changes 30-99 lines, ignoring generated files.