Home Original page

fix(dist): add license for swagger-ui & reset use stage to false in ci yml by VGalaxies · Pull Request #2706 · apache/hugegraph

@VGalaxies

@VGalaxies

@dosubot dosubot bot added the size:XS

This PR changes 0-9 lines, ignoring generated files.

label

Dec 13, 2024

@codecov

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.99%. Comparing base (f147460) to head (b11ccc4).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #2706      +/-   ##
============================================
+ Coverage     46.98%   46.99%   +0.01%     
+ Complexity      998      823     -175     
============================================
  Files           745      745              
  Lines         60060    60060              
  Branches       7669     7669              
============================================
+ Hits          28220    28227       +7     
- Misses        29012    29015       +3     
+ Partials       2828     2818      -10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

imbajin

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should disable the 'stage' param in this PR

Also, mark a TODO for using common/rpc dependency directly

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, mark a TODO for using common/rpc dependency directly

where to mark?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, mark a TODO for using common/rpc dependency directly

where to mark?

Using the stage param of the server-ci.yml (one is enough) + usage in the pom.xml (common/rpc)

@VGalaxies

@dosubot dosubot bot added size:S

This PR changes 10-29 lines, ignoring generated files.

and removed size:XS

This PR changes 0-9 lines, ignoring generated files.

labels

Dec 16, 2024

@dosubot dosubot bot added size:M

This PR changes 30-99 lines, ignoring generated files.

and removed size:S

This PR changes 10-29 lines, ignoring generated files.

labels

Dec 25, 2024

@VGalaxies

@VGalaxies VGalaxies changed the title fix(dist): add license for swagger-ui fix(dist): add license for swagger-ui & reset use stage to false in ci yml

Dec 25, 2024

@imbajin

imbajin

@dosubot dosubot bot added the lgtm

This PR has been approved by a maintainer

label

Dec 26, 2024

JackyYangPassion