add conf entry jdbc.storage_engine to change storage engine by wenzhenghu · Pull Request #555

add conf entry jdbc.storage_engine to change storage engine by wenzhenghu · Pull Request #555 · apache/hugegraph

Merged

zhoney merged 7 commits intoapache:masterfrom

wenzhenghu:myrocks

Jun 5, 2019

Merged

add conf entry jdbc.storage_engine to change storage engine#555
zhoney merged 7 commits intoapache:masterfrom
wenzhenghu:myrocks

Conversation

Copy link

Contributor

wenzhenghu commented
Jun 5, 2019

default innodb, could change to rocksdb, but not myisam, as hugegraph will create large index that myisam could not support ("Specified key was too long; max key length is 1000 bytes")

wenzhenghu and others added 3 commits

June 5, 2019 10:26

add conf entry jdbc.storage_engine to change storage engine

650aef7

add conf entry jdbc.storage_engine to change storage engine

2bbe2ca

add conf entry jdbc.storage_engine to change storage engine

464ce74

Copy link

CLAassistant commented
Jun 5, 2019
•

edited

Loading

All committers have signed the CLA.

javeme requested changes Jun 5, 2019

View reviewed changes

hugegraph-mysql/src/main/java/com/baidu/hugegraph/backend/store/mysql/MysqlSessions.java Outdated Show resolved Hide resolved

hugegraph-mysql/src/main/java/com/baidu/hugegraph/backend/store/mysql/MysqlTable.java Show resolved Hide resolved

javeme mentioned this pull request

Jun 5, 2019

add conf entry mysql.engine to change storage engine of mysql, defaul… #553

Closed

hzwenzhh added 2 commits

June 5, 2019 11:36

add conf entry jdbc.storage_engine to change storage engine

e89d897

add conf entry jdbc.storage_engine to change storage engine

982d543

Copy link

codecov bot commented
Jun 5, 2019
•

edited

Loading

Codecov Report

Merging #555 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #555      +/-   ##
============================================
+ Coverage     70.19%   70.21%   +0.01%     
- Complexity     3418     3419       +1     
============================================
  Files           216      216              
  Lines         16461    16465       +4     
  Branches       2351     2351              
============================================
+ Hits          11555    11561       +6     
- Misses         3650     3651       +1     
+ Partials       1256     1253       -3

Impacted Files	Coverage Δ	Complexity Δ
...raph/backend/store/postgresql/PostgresqlTable.java	`96.72% <ø> (ø)`	`17 <0> (ø)`	⬇️
...u/hugegraph/backend/store/mysql/MysqlSessions.java	`70.9% <100%> (+0.78%)`	`18 <0> (+1)`	⬆️
...du/hugegraph/backend/store/mysql/MysqlOptions.java	`95.65% <100%> (+0.41%)`	`3 <0> (ø)`	⬇️
...aidu/hugegraph/backend/store/mysql/MysqlTable.java	`76.84% <100%> (+0.07%)`	`70 <1> (ø)`	⬇️
...ain/java/com/baidu/hugegraph/task/TaskManager.java	`60.86% <0%> (-4.35%)`	`10% <0%> (-1%)`
...va/com/baidu/hugegraph/backend/cache/RamCache.java	`72.54% <0%> (+0.39%)`	`45% <0%> (+1%)`	⬆️
...du/hugegraph/backend/tx/GraphIndexTransaction.java	`80% <0%> (+0.47%)`	`146% <0%> (ø)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3a3c35...4cb62c2. Read the comment docs.