improve implicit parameter name max_depth by javeme · Pull Request #563 · apache/hugegraph
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 583
Conversation
Copy link
Contributor
javeme
commented
Jun 11, 2019
javeme
commented
improve the implicit parameter name in the error message
fixed #519
javeme
mentioned this pull request
Copy link
Codecov Report
Merging #563 into master will increase coverage by
0.31%.
The diff coverage isn/a.
@@ Coverage Diff @@ ## master #563 +/- ## ============================================ + Coverage 70.22% 70.54% +0.31% - Complexity 3418 3457 +39 ============================================ Files 216 216 Lines 16465 16600 +135 Branches 2351 2375 +24 ============================================ + Hits 11563 11710 +147 + Misses 3646 3641 -5 + Partials 1256 1249 -7
| Impacted Files | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| ...raph/backend/store/rocksdb/RocksDBStdSessions.java | 69.84% <0%> (+0.61%) |
24% <0%> (+1%) |
⬆️ |
| ...n/java/com/baidu/hugegraph/task/TaskScheduler.java | 53.52% <0%> (+0.82%) |
27% <0%> (ø) |
⬇️ |
| .../backend/store/cassandra/CassandraSessionPool.java | 59.37% <0%> (+1.04%) |
13% <0%> (ø) |
⬇️ |
| ...egraph/backend/store/cassandra/CassandraStore.java | 64.88% <0%> (+1.14%) |
44% <0%> (+2%) |
⬆️ |
| .../hugegraph/backend/store/rocksdb/RocksDBStore.java | 58.07% <0%> (+1.15%) |
43% <0%> (+3%) |
⬆️ |
| ...aidu/hugegraph/backend/store/hbase/HbaseStore.java | 72.07% <0%> (+1.29%) |
26% <0%> (ø) |
⬇️ |
| ...in/java/com/baidu/hugegraph/schema/IndexLabel.java | 69.11% <0%> (+1.47%) |
25% <0%> (+1%) |
⬆️ |
| ...raph/backend/store/postgresql/PostgresqlTable.java | 98.36% <0%> (+1.63%) |
18% <0%> (+1%) |
⬆️ |
| ...e/src/main/java/com/baidu/hugegraph/HugeGraph.java | 72.78% <0%> (+1.89%) |
64% <0%> (+3%) |
⬆️ |
| ...ugegraph/backend/store/BackendProviderFactory.java | 72.41% <0%> (+3.44%) |
4% <0%> (+1%) |
⬆️ |
| ... and 6 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 033c387...976953d. Read the comment docs.
Improve the implicit parameter name in the error message fixed #519 Change-Id: I03ef4ef2b7adfc02129c774f8e45d8f935e61874
javeme
force-pushed
the
max_depth
branch
from
3286416 to
976953d
Compare
Linary approved these changes Jun 12, 2019
zhoney approved these changes Jun 12, 2019
zhoney
merged commit
88f249a
into
master
zhoney
deleted the
max_depth
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants