[MPMD-369] Make integration tests robust against system encoding by elharo · Pull Request #122 · apache/maven-pmd-plugin

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@elharo

Copy link Copy Markdown

Contributor

@elharo elharo commented

Apr 5, 2023

edited

Loading

There are more instances to be fixed but I think these two are the major offenders that break the integration tests.

@elharo elharo requested a review from michael-o

April 5, 2023 17:54
Copy link Copy Markdown

Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bah, the dreaded file reader.

@elharo elharo merged commit 2530d84 into master

Apr 6, 2023

@elharo elharo deleted the cherrypick branch

April 6, 2023 11:59

@jira-importer

Copy link Copy Markdown

Resolve #339

1 similar comment

@jira-importer

Copy link Copy Markdown

Resolve #339

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michael-o michael-o michael-o approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@elharo @jira-importer @michael-o