Declare javax.inject dependency by elharo · Pull Request #197 · apache/maven-pmd-plugin
Navigation Menu
{{ message }}
apache / maven-pmd-plugin Public
- Notifications You must be signed in to change notification settings
- Fork 52
Conversation
elharo
requested a review
from Bukama
elharo
marked this pull request as ready for review
Copy link Copy Markdown
Contributor
Bukama
commented
Apr 23, 2025
Bukama commented
Apr 23, 2025Thought we do DI via sisu - however in the build sisu-inject-plexusis excluded?
elharo
deleted the
dep
branch
github-actions
bot
added this to the
3.26.1 milestone
github-actions
bot
added
the
maintenance
label
github-actions
bot
assigned
elharo
Copy link Copy Markdown
Contributor Author
elharo
commented
Apr 23, 2025
elharo commented
Apr 23, 2025We have so many variants of DI, and I have no idea which is used where at this point.
olamy reviewed Apr 23, 2025
| <dependency> | ||
| <groupId>javax.inject</groupId> | ||
| <artifactId>javax.inject</artifactId> | ||
| <version>1</version> |
Copy link Copy Markdown
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't be provided scope?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment