Home Original page

Introduce service executors for CPD, PMD executors by slawekjaranowski · Pull Request #206 · apache/maven-pmd-plugin

@slawekjaranowski

Standard mojos and reports have different parent classes, so we need to extract tasks which both will execute.

We cannot use one abstract for both.

@slawekjaranowski 

Standard mojos and reports have different parent classes,
so we need to extract tasks which both will execute.

We cannot use one abstract for both.

@adangel adangel changed the title Introduce service executors for Cpd, Pdm executors Introduce service executors for CPD, PMD executors

May 23, 2025

adangel

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I wonder, whether we could merge CpdExecutor + CpdServiceExecutor and PmdExecutor + PmdServiceExecutor and Executor + ServiceExecutor. Having both an "executor" and a "service executor" sounds unnecessary to me...

@slawekjaranowski @adangel 

Co-authored-by: Andreas Dangel <andreas.dangel@adangel.org>

@slawekjaranowski

LGTM.

I wonder, whether we could merge CpdExecutor + CpdServiceExecutor and PmdExecutor + PmdServiceExecutor and Executor + ServiceExecutor. Having both an "executor" and a "service executor" sounds unnecessary to me...

CpdExecutor/PmdExecutor are use in fokr mode with main static method .... but ServiceExecutor I use a constructor for inject needed components.