Bug: Reproducer and fix for #1583 by cstamas · Pull Request #1585 · apache/maven-resolver
added 8 commits
September 13, 2025 18:27
If the cycle is among winner nodes. Created UT as reproducer but we will need more.
But all these fail the classic CR not the path!
Created UT that reproduces: classic CR passes ok, but path CR fails, leave cycle in.
cstamas
changed the title
Bug: Reproducer for #1583
Bug: Reproducer and fix for #1583
cstamas
marked this pull request as ready for review
As other nodes will be marked as losers anyway (and probably eliminated)
Original code LEFT OUT some nodes from Path graph, hence implicitly left cycles in as well (as Path graph was unaware of it). Now we make sure all cycle starting nodes are added as well, AND we make sure they are always "claimed" (winner or loser) as then the DN graph is adjusted properly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters