fix(send): try to use command v2 to send messages by ShannonDing · Pull Request #225 · apache/rocketmq-client-cpp
Conversation
Copy link
Member
ShannonDing
commented
Jan 11, 2020
ShannonDing
commented
What is the purpose of the change
[fix #189] fix(send): try to use command v2 to send messages
ShannonDing added 6 commits
January 10, 2020 22:14
ShannonDing
added this to the
1.2.5 milestone
ShannonDing
requested review from
duhenglucky,
jonnxu and
vongosling
Copy link
Codecov Report
Merging #225 into master will increase coverage by
0.86%.
The diff coverage is98.85%.
@@ Coverage Diff @@ ## master #225 +/- ## ========================================== + Coverage 51.01% 51.88% +0.86% ========================================== Files 173 174 +1 Lines 10701 10857 +156 ========================================== + Hits 5459 5633 +174 + Misses 5242 5224 -18
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/common/AsyncCallbackWrap.cpp | 9.58% <ø> (ø) |
⬆️ |
| src/common/AsyncCallbackWrap.h | 33.33% <ø> (ø) |
⬆️ |
| src/MQClientFactory.cpp | 18.45% <0%> (ø) |
⬆️ |
| src/producer/DefaultMQProducer.cpp | 5.46% <0%> (-0.02%) |
⬇️ |
| src/MQClientAPIImpl.cpp | 16.49% <100%> (+0.35%) |
⬆️ |
| test/src/protocol/CommandHeaderTest.cpp | 100% <100%> (ø) |
⬆️ |
| test/src/common/MQVersionTest.cpp | 100% <100%> (ø) |
|
| src/protocol/CommandHeader.h | 76.82% <100%> (+6.06%) |
⬆️ |
| src/common/MQVersion.cpp | 100% <100%> (+100%) |
⬆️ |
| src/common/VirtualEnvUtil.cpp | 100% <100%> (+100%) |
⬆️ |
| ... and 6 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 54a3878...8ce4bd5. Read the comment docs.
ShannonDing
merged commit
b50d99c
into
apache:master
ShannonDing
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment