feat(memleak): remove mem leak in factory schedule task. by ShannonDing · Pull Request #227 · apache/rocketmq-client-cpp

Conversation

@ShannonDing

Copy link

Member

@ShannonDing ShannonDing commented

Jan 13, 2020

edited

Loading

What is the purpose of the change

fix #226
feat(memleak): remove mem leak in factory schedule task.

@ShannonDing ShannonDing added the enhancement

New feature or request

label

Jan 13, 2020

@ShannonDing ShannonDing added this to the 1.2.5 milestone

Jan 13, 2020

@codecov-io

Copy link

Codecov Report

Merging #227 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #227      +/-   ##
==========================================
- Coverage   51.88%   51.87%   -0.01%     
==========================================
  Files         174      174              
  Lines       10857    10858       +1     
==========================================
  Hits         5633     5633              
- Misses       5224     5225       +1
Impacted Files Coverage Δ
src/MQClientFactory.cpp 18.45% <0%> (ø) ⬆️
src/common/MQClient.cpp 38.23% <0%> (-0.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b50d99c...f2b1a67. Read the comment docs.

@ShannonDing ShannonDing merged commit 555e19d into apache:master

Jan 13, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement

New feature or request

Projects

None yet

Milestone

1.2.5

Development

Successfully merging this pull request may close these issues.

There seems some memory leak in schedule task.

2 participants

@ShannonDing @codecov-io