feat(version): add maxConsumerTimes to support higher client version by ShannonDing · Pull Request #230 · apache/rocketmq-client-cpp
Conversation
Copy link
Member
ShannonDing
commented
Jan 14, 2020
ShannonDing
commented
What is the purpose of the change
close #229
feat(version): add maxConsumerTimes to support higher client version
ShannonDing added 3 commits
January 14, 2020 11:48
ShannonDing
added this to the
1.2.5 milestone
ShannonDing
requested a review
from jonnxu
Copy link
codecov-io
commented
Jan 14, 2020
codecov-io commented
Jan 14, 2020Codecov Report
Merging #230 into master will increase coverage by
0.45%.
The diff coverage is83.56%.
@@ Coverage Diff @@ ## master #230 +/- ## ========================================== + Coverage 51.87% 52.33% +0.45% ========================================== Files 174 174 Lines 10858 10931 +73 ========================================== + Hits 5633 5721 +88 + Misses 5225 5210 -15
| Impacted Files | Coverage Δ | |
|---|---|---|
| include/DefaultMQPushConsumer.h | 0% <ø> (ø) |
⬆️ |
| src/protocol/CommandHeader.h | 79.26% <ø> (+2.43%) |
⬆️ |
| src/consumer/DefaultMQPushConsumer.cpp | 6.44% <0%> (-0.1%) |
⬇️ |
| src/consumer/ConsumeMessageConcurrentlyService.cpp | 0% <0%> (ø) |
⬆️ |
| src/MQClientAPIImpl.cpp | 20.28% <100%> (+3.79%) |
⬆️ |
| src/protocol/CommandHeader.cpp | 85.44% <100%> (+2.22%) |
⬆️ |
| test/src/protocol/CommandHeaderTest.cpp | 100% <100%> (ø) |
⬆️ |
| test/src/MQClientAPIImpTest.cpp | 98.37% <100%> (+0.26%) |
⬆️ |
| ... and 1 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 555e19d...4456300. Read the comment docs.
ShannonDing
merged commit
46dd8f5
into
apache:master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment