feat(callback): use start pointer to manager callbacks by ShannonDing · Pull Request #232 · apache/rocketmq-client-cpp
Navigation Menu
{{ message }}
apache / rocketmq-client-cpp Public
- Notifications You must be signed in to change notification settings
- Fork 165
Merged
feat(callback): use start pointer to manager callbacks#232
ShannonDing merged 1 commit intoapache:masterfrom
feat(callback): use start pointer to manager callbacks#232
ShannonDing merged 1 commit intoapache:masterfrom
Conversation
Copy link
Member
ShannonDing
commented
Jan 15, 2020
ShannonDing
commented
What is the purpose of the change
feat(callback): use start pointer to manager callbacks
ShannonDing
added this to the
1.2.5 milestone
ShannonDing
requested a review
from jonnxu
ShannonDing
merged commit
f968f57
into
apache:master
Copy link
Contributor
I think use unique_ptr is better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment