feat(consumer): remove event if consumer service shutdown by ShannonDing · Pull Request #233 · apache/rocketmq-client-cpp
Conversation
Copy link
Member
ShannonDing
commented
Jan 16, 2020
ShannonDing
commented
What is the purpose of the change
feat(consumer): remove event if consumer service shutdown
ShannonDing
added this to the
1.2.5 milestone
Copy link
codecov-io
commented
Jan 16, 2020
codecov-io commented
Jan 16, 2020Codecov Report
Merging #233 into master will decrease coverage by
0.03%.
The diff coverage is0%.
@@ Coverage Diff @@ ## master #233 +/- ## ========================================== - Coverage 52.87% 52.83% -0.04% ========================================== Files 174 174 Lines 10986 10994 +8 ========================================== Hits 5809 5809 - Misses 5177 5185 +8
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/consumer/DefaultMQPushConsumer.cpp | 6.4% <0%> (-0.05%) |
⬇️ |
| src/consumer/ConsumeMessageConcurrentlyService.cpp | 0% <0%> (ø) |
⬆️ |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update f968f57...56e85bc. Read the comment docs.
ShannonDing
merged commit
fd29759
into
apache:master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment