feat(producer): add regionId support in the send result by ShannonDing · Pull Request #258 · apache/rocketmq-client-cpp
Conversation
Copy link
Member
ShannonDing
commented
Feb 24, 2020
ShannonDing
commented
What is the purpose of the change
feat(producer): add regionId support in the send result
ShannonDing added 3 commits
February 24, 2020 17:21… support message trace.
… support message trace.
… support message trace.
ShannonDing
added this to the
2.0.1 milestone
Copy link
codecov-io
commented
Feb 24, 2020
codecov-io commented
Feb 24, 2020Codecov Report
Merging #258 into master will increase coverage by
0.16%.
The diff coverage is93.54%.
@@ Coverage Diff @@ ## master #258 +/- ## ========================================== + Coverage 57.69% 57.86% +0.16% ========================================== Files 182 182 Lines 11652 11680 +28 ========================================== + Hits 6723 6759 +36 + Misses 4929 4921 -8
| Impacted Files | Coverage Δ | |
|---|---|---|
| include/SendResult.h | 0% <ø> (ø) |
⬆️ |
| src/MQClientAPIImpl.cpp | 24.48% <100%> (ø) |
⬆️ |
| src/protocol/CommandHeader.cpp | 85.71% <100%> (+0.27%) |
⬆️ |
| test/src/protocol/CommandHeaderTest.cpp | 100% <100%> (ø) |
⬆️ |
| test/src/producer/DefaultMQProducerImplTest.cpp | 98.26% <100%> (+0.03%) |
⬆️ |
| src/protocol/CommandHeader.h | 79.76% <100%> (+0.49%) |
⬆️ |
| src/producer/SendResult.cpp | 95.65% <75%> (+21.96%) |
⬆️ |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 41d7c35...b7cd030. Read the comment docs.
ShannonDing
merged commit
e0f05d6
into
apache:master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment