Home Original page

fix: Fix logger name for http based loggers by Pijukatel · Pull Request #1023 · apify/crawlee-python

@Pijukatel

@Pijukatel

@Pijukatel Pijukatel added the t-tooling

Issues with this label are in the ownership of the tooling team.

label

Feb 25, 2025

vdusek

@vdusek vdusek left a comment •

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use "Crawler".__name__ in the tests rather than their names in the form as string literals? Thanks.

@janbuchar

Could we use "Crawler".__name__ in the tests rather than their names in the form as string literals? Thanks.

That borders on circular logic though 🙂 I slightly prefer copying the name in the tests so that they don't depend on the implementation, even though it's a super trivial dependency here.

vdusek