fix: Fix flaky test_common_headers_and_user_agent by Pijukatel · Pull Request #1030 · apify/crawlee-python
Navigation Menu
{{ message }}
apify / crawlee-python Public
- Notifications You must be signed in to change notification settings
- Fork 705
Merged
fix: Fix flaky test_common_headers_and_user_agent#1030
fix: Fix flaky test_common_headers_and_user_agent#1030
Conversation
Copy link
Collaborator
Description
In header network(source for generated headers) possible values for accept are under two separate keys. Use both in tests.
Issues
labels
Feb 27, 2025
github-actions
bot
assigned
Pijukatel
github-actions
bot
added this to the
109th sprint - Tooling team milestone
github-actions
bot
added
the
tested
label
Feb 27, 2025
Pijukatel
requested a review
from Mantisus
Pijukatel
marked this pull request as ready for review
Mantisus approved these changes Feb 27, 2025
Copy link
Collaborator
Mantisus
left a comment
Mantisus
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Copy link
Collaborator
Mantisus
commented
Feb 27, 2025
Mantisus commented
Feb 27, 2025Looks like the new redirect tests are crashing on our httpbin instance...
Pijukatel
deleted the
flaky-coommon-headers-test
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment