fix: Add `browserforge` to mandatory dependencies by Pijukatel · Pull Request #1044 · apify/crawlee-python

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@Pijukatel

Copy link

Collaborator

Description

Browserforge is now used for header generation not only for PlaywrightCrawler, but also for http clients and so it needs to be mandatory dependency.

@github-actions github-actions bot added this to the 109th sprint - Tooling team milestone

Mar 3, 2025

@Pijukatel Pijukatel added bug

Something isn't working.

adhoc

Ad-hoc unplanned task added during the sprint.

labels

Mar 3, 2025

@github-actions github-actions bot added the t-tooling

Issues with this label are in the ownership of the tooling team.

label

Mar 3, 2025

@Pijukatel Pijukatel marked this pull request as ready for review

March 3, 2025 14:51
Copy link

Collaborator

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pijukatel Pijukatel merged commit ddfbde8 into master

Mar 3, 2025

23 checks passed

@Pijukatel Pijukatel deleted the browserforge-dependency branch

March 3, 2025 14:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vdusek vdusek vdusek approved these changes

Assignees

@Pijukatel Pijukatel

Labels

adhoc

Ad-hoc unplanned task added during the sprint.

bug

Something isn't working.

t-tooling

Issues with this label are in the ownership of the tooling team.

Projects

None yet

Milestone

109th sprint - Tooling team

Development

Successfully merging this pull request may close these issues.

2 participants

@Pijukatel @vdusek