fix: Remove tmp folder for PlaywrightCrawler in non-headless mode by Mantisus · Pull Request #1046 · apify/crawlee-python
Navigation Menu
{{ message }}
apify / crawlee-python Public
- Notifications You must be signed in to change notification settings
- Fork 705
Merged
fix: Remove tmp folder for PlaywrightCrawler in non-headless mode#1046
vdusek merged 7 commits intoapify:masterfrom
fix: Remove tmp folder for PlaywrightCrawler in non-headless mode#1046
vdusek merged 7 commits intoapify:masterfrom
Conversation
Copy link
Collaborator
Description
- Fix a bug removing a temporary folder for non-headless mode. I saved an attempt to remove a folder on the
closeevent, for when for some reason the browser crashes and the context is closed by the Playwright mechanisms
Mantisus
requested review from
Pijukatel and
vdusek
and removed request for
vdusek
Mantisus
self-assigned this
vdusek approved these changes Mar 4, 2025
Copy link
Collaborator
vdusek
left a comment
vdusek
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pijukatel reviewed Mar 4, 2025
Copy link
Collaborator
Pijukatel
left a comment
Pijukatel
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add tiny test for this scenario that checks that the dir exists and is deleted when close is called.
src/crawlee/browsers/_playwright_browser.py
Show resolved
Hide resolved
src/crawlee/browsers/_playwright_browser.py Show resolved Hide resolved
Mantisus added 4 commits
March 4, 2025 14:17
Mantisus
force-pushed
the
fix-remove-tmp-files
branch
2 times, most recently
from
83992a0 to
639c797
Compare
Mantisus
force-pushed
the
fix-remove-tmp-files
branch
from
639c797 to
479dd4c
Compare
Pijukatel
self-requested a review
Pijukatel approved these changes Mar 5, 2025
ROYOSTI
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants