fix: add port for `same-origin` strategy check by Mantisus · Pull Request #1096 · apify/crawlee-python

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@Mantisus

Copy link

Collaborator

Description

  • add port for same-origin strategy check

@Mantisus Mantisus requested review from janbuchar and vdusek

March 17, 2025 22:26

@Mantisus Mantisus self-assigned this

Mar 17, 2025

@Mantisus

Copy link

Collaborator Author

Mantisus commented

Mar 17, 2025

edited

Loading

According to the documentation, we should also check the port.

Copy link

Collaborator

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link

Collaborator

@janbuchar janbuchar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vdusek vdusek merged commit 9e24598 into apify:master

Mar 18, 2025

23 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janbuchar janbuchar janbuchar approved these changes

@vdusek vdusek vdusek approved these changes

Assignees

@Mantisus Mantisus

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Mantisus @janbuchar @vdusek