Integrate automated PyPI releases into CI by vdusek · Pull Request #125 · apify/crawlee-python

- name: Determine release type
id: determine-release-type
run: |
if [[ ${{ github.event_name }} = release ]]; then

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fine for now, but in the long run i would like to see similar mechanism as we have in crawlee - stable releases are triggered via workflow dispatch, and they modify the changelog as well as create the git tag and its corresponding GH release notes. as if you would trigger this by creating a GH release first, it means you are responsible for creating the changelog - i know there is button in the UI for that nowadays, but it ignores commits to master and doesn't handle conventional commits properly (e.g. it adds everything including chore commits)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK this is copied from python SDK, do we want to make those changes in both repos?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be done later as part of #18

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, ideally, we will migrate all repositories to the new system, but we agreed with Vlada to keep this as is for now and deal with this later (even after the public launch, functionality has priority over this). Also @vladfrangu should prepare a new mechanism for releasing the CLI which might help here too, as it should do the same, workflow dispatch will trigger changelog update and create new git tag and gh release, and this part should work the same regardless of the language.