refactor!: Change method `HttpResponse.read` from sync to async by Mantisus · Pull Request #1296 · apify/crawlee-python
Description
- Makes the
readmethod forHttpResponseasynchronous. This is more consistent in a fully asynchronous framework. More flexible than a synchronous method
Mantisus
changed the title
refactor! change method
refactor!: Change method read for Response from sync to asyncread for Response from sync to async
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense, thanks, just please describe it in the upgrading guide 🙂.
Mantisus
changed the title
refactor!: Change method
refactor!: Change method read for Response from sync to asyncread for HttpResponse from sync to async
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
vdusek
changed the title
refactor!: Change method
refactor!: Change method read for HttpResponse from sync to asyncHttpResponse.read from sync to async
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters