fix: Update templates to handle optional httpx client by Pijukatel · Pull Request #1440 · apify/crawlee-python
Navigation Menu
{{ message }}
apify / crawlee-python Public
- Notifications You must be signed in to change notification settings
- Fork 705
Merged
Conversation
Copy link
Collaborator
Pijukatel
commented
Sep 30, 2025
Pijukatel
commented
Description
- Update templates to handle optional httpx client.
Testing
- Running E2E template tests
github-actions
bot
assigned
Pijukatel
github-actions
bot
added this to the
124th sprint - Tooling team milestone
github-actions
bot
added
the
t-tooling
label
Sep 30, 2025
Pijukatel
requested a review
from vdusek
Copy link
Collaborator Author
Failed master E2E tests:
https://github.com/apify/crawlee-python/actions/runs/18120549849
On this branch E2E tests:
https://github.com/apify/crawlee-python/actions/runs/18130587136
- Failing Camoufox templates are some performance issue as the templates are running very slowly with Camoufox.
Pijukatel
marked this pull request as ready for review
vdusek reviewed Oct 1, 2025
src/crawlee/project_template/{{cookiecutter.project_name}}/pyproject.toml
Show resolved
Hide resolved
src/crawlee/project_template/{{cookiecutter.project_name}}/pyproject.toml Show resolved Hide resolved
vdusek approved these changes Oct 1, 2025
Copy link
Collaborator
vdusek
left a comment
vdusek
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
vdusek
mentioned this pull request
Copy link
Collaborator Author
Pijukatel
commented
Oct 2, 2025
Pijukatel commented
Oct 2, 2025Ignoring the failing test due to #1441
Pijukatel
deleted the
update-templates-to-handle-optional-httpx
branch
janbuchar
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment