fix: Add storages name validation by Mantisus · Pull Request #1457 · apify/crawlee-python

@Mantisus

Copy link

Collaborator

@Mantisus Mantisus commented

Oct 6, 2025

Description

  • Added name validation for storages in accordance with Apify platform restrictions

Issues

Testing

  • Added new tests to verify correct validation.

@Mantisus Mantisus requested review from Pijukatel and vdusek and removed request for vdusek

October 6, 2025 16:29

@Mantisus Mantisus self-assigned this

Oct 6, 2025

@Mantisus Mantisus requested a review from vdusek

October 6, 2025 16:29

@vdusek vdusek requested review from janbuchar and removed request for Pijukatel

October 7, 2025 07:59

@vdusek

Copy link

Collaborator

vdusek commented

Oct 7, 2025

assigning @janbuchar as @Pijukatel is off for this week

vdusek

Copy link

Collaborator

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I'm wondering, shouldn't we add this new enforcement on this level to https://crawlee.dev/python/docs/upgrading/upgrading-to-v1?

Mantisus and others added 2 commits

October 7, 2025 15:10
Co-authored-by: Vlada Dusek <v.dusek96@gmail.com>
Co-authored-by: Vlada Dusek <v.dusek96@gmail.com>

@Mantisus Mantisus requested a review from vdusek

October 7, 2025 12:22

@vdusek

Copy link

Collaborator

vdusek commented

Oct 7, 2025

@Mantisus sorry did you overlook this:

Thanks. I'm wondering, shouldn't we add this new enforcement on this level to https://crawlee.dev/python/docs/upgrading/upgrading-to-v1?

What do you think about that?

@Mantisus

Copy link

Collaborator Author

Mantisus commented

Oct 7, 2025

edited

Loading

Sorry, yes

What do you think about that?

I'm not sure, because it's a fix. And we didn't include fixes in the upgrading guide, if I'm not mistaken.

@Mantisus

ap upgrading guides

010f986

@Mantisus

Copy link

Collaborator Author

Mantisus commented

Oct 7, 2025

The upgrading guide was updated after discussing on Slack

vdusek reacted with thumbs up emoji

@vdusek

wording

90c3108

@vdusek vdusek merged commit 84de11a into apify:master

Oct 7, 2025

18 of 19 checks passed

@vdusek vdusek mentioned this pull request

Oct 29, 2025