fix: Add storages name validation by Mantisus · Pull Request #1457 · apify/crawlee-python
Copy link
Collaborator
Mantisus
commented
Oct 6, 2025
Mantisus
commented
Description
- Added name validation for storages in accordance with Apify platform restrictions
Issues
- Closes: Validate storage names before passing them to the storage client #1434
- Relates: All crawlee persistence names should be valid names for Apify platform #1354
Testing
- Added new tests to verify correct validation.
Mantisus added 2 commits
October 6, 2025 16:14
Mantisus
requested review from
Pijukatel and
vdusek
and removed request for
vdusek
Mantisus
self-assigned this
Mantisus
requested a review
from vdusek
vdusek
requested review from
janbuchar
and removed request for
Pijukatel
Copy link
Collaborator
vdusek
commented
Oct 7, 2025
vdusek commented
Oct 7, 2025assigning @janbuchar as @Pijukatel is off for this week
vdusek reviewed Oct 7, 2025
Copy link
Collaborator
vdusek
left a comment
vdusek
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I'm wondering, shouldn't we add this new enforcement on this level to https://crawlee.dev/python/docs/upgrading/upgrading-to-v1?
src/crawlee/storages/_base.py
Outdated
Show resolved
Hide resolved
src/crawlee/storages/_base.py Outdated Show resolved Hide resolved
src/crawlee/storages/_storage_instance_manager.py
Outdated
Show resolved
Hide resolved
src/crawlee/storages/_storage_instance_manager.py Outdated Show resolved Hide resolved
tests/unit/storages/test_dataset.py
Show resolved
Hide resolved
tests/unit/storages/test_dataset.py Show resolved Hide resolved
janbuchar approved these changes Oct 7, 2025
Mantisus and others added 2 commits
October 7, 2025 15:10Co-authored-by: Vlada Dusek <v.dusek96@gmail.com>
Co-authored-by: Vlada Dusek <v.dusek96@gmail.com>
Mantisus
requested a review
from vdusek
Copy link
Collaborator
vdusek
commented
Oct 7, 2025
vdusek commented
Oct 7, 2025@Mantisus sorry did you overlook this:
Thanks. I'm wondering, shouldn't we add this new enforcement on this level to https://crawlee.dev/python/docs/upgrading/upgrading-to-v1?
What do you think about that?
Copy link
Collaborator Author
Sorry, yes
What do you think about that?
I'm not sure, because it's a fix. And we didn't include fixes in the upgrading guide, if I'm not mistaken.
Copy link
Collaborator Author
Mantisus
commented
Oct 7, 2025
Mantisus commented
Oct 7, 2025The upgrading guide was updated after discussing on Slack
vdusek
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters