fix: Fix `same-domain` strategy ignoring public suffix by Pijukatel · Pull Request #1572 · apify/crawlee-python
Navigation Menu
{{ message }}
apify / crawlee-python Public
- Notifications You must be signed in to change notification settings
- Fork 705
Merged
fix: Fix same-domain strategy ignoring public suffix #1572
fix: Fix same-domain strategy ignoring public suffix #1572
Conversation
Copy link
Collaborator
Description
- Use
top_domain_under_public_suffixinstead of justdomainwhen comparing domains insame-domainstrategy.
Issues
Testing
- Added unit test
Checklist
- CI passed
github-actions
bot
assigned
Pijukatel
github-actions
bot
added this to the
128th sprint - Tooling team milestone
github-actions
bot
added
t-tooling
labels
Nov 18, 2025
Pijukatel
requested review from
Mantisus and
vdusek
Pijukatel
marked this pull request as ready for review
vdusek approved these changes Nov 19, 2025
Copy link
Collaborator
vdusek
left a comment
vdusek
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pijukatel
deleted the
fix-same-domain
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment