fix: make timedelta_ms accept string-encoded numbers by janbuchar · Pull Request #190 · apify/crawlee-python
Navigation Menu
{{ message }}
apify / crawlee-python Public
- Notifications You must be signed in to change notification settings
- Fork 705
Merged
fix: make timedelta_ms accept string-encoded numbers#190
fix: make timedelta_ms accept string-encoded numbers#190
Conversation
Copy link
Collaborator
janbuchar
commented
Jun 18, 2024
janbuchar
commented
This is helpful when working with configuration in environment variables
labels
Jun 18, 2024
janbuchar
requested a review
from vdusek
github-actions
bot
assigned
janbuchar
github-actions
bot
added this to the
92nd sprint - Tooling team milestone
vdusek approved these changes Jun 18, 2024
Copy link
Collaborator
vdusek
left a comment
vdusek
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
janbuchar
merged commit
d8426ff
into
master
janbuchar
deleted the
better-timedelta-ms
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment