fix: Improve compatibility between ProxyConfiguration and its SDK counterpart by janbuchar · Pull Request #201 · apify/crawlee-python

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@janbuchar

Copy link

Collaborator

No description provided.

@janbuchar janbuchar added t-tooling

Issues with this label are in the ownership of the tooling team.

adhoc

Ad-hoc unplanned task added during the sprint.

labels

Jun 20, 2024

@janbuchar janbuchar requested a review from vdusek

June 20, 2024 07:53

@github-actions github-actions bot added this to the 92nd sprint - Tooling team milestone

Jun 20, 2024
Copy link

Collaborator

@vdusek vdusek left a comment

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just fix tests 🙂

@github-actions github-actions bot added the tested

Temporary label used only programatically for some analytics.

label

Jun 20, 2024

@janbuchar janbuchar merged commit 1a76124 into master

Jun 20, 2024

@janbuchar janbuchar deleted the proxy-configuration-fixes branch

June 20, 2024 11:47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vdusek vdusek vdusek approved these changes

Assignees

@janbuchar janbuchar

Labels

adhoc

Ad-hoc unplanned task added during the sprint.

t-tooling

Issues with this label are in the ownership of the tooling team.

tested

Temporary label used only programatically for some analytics.

Projects

None yet

Milestone

92nd sprint - Tooling team

Development

Successfully merging this pull request may close these issues.

2 participants

@janbuchar @vdusek