Home Original page

feat: BasicCrawler.export_data helper by janbuchar · Pull Request #222 · apify/crawlee-python

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@janbuchar janbuchar added the t-tooling

Issues with this label are in the ownership of the tooling team.

label

Jun 24, 2024

@janbuchar janbuchar requested a review from vdusek

June 24, 2024 14:50

@github-actions github-actions bot added this to the 92nd sprint - Tooling team milestone

Jun 24, 2024

@github-actions github-actions bot added the tested

Temporary label used only programatically for some analytics.

label

Jun 24, 2024
Copy link

Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Pull Request Tookit has failed!

None of the pull request and linked issue has estimate

Copy link

Collaborator

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just naming and one more thing: the class ExportToKwargs - couldn't it be removed now?

@janbuchar

Copy link

Collaborator Author

the class ExportToKwargs - couldn't it be removed now?

No, it's still used in Dataset.export_to.

vdusek reacted with thumbs up emoji

@janbuchar janbuchar merged commit 237ec78 into master

Jun 25, 2024

@janbuchar janbuchar deleted the export-data-helper branch

June 25, 2024 09:53

@janbuchar janbuchar mentioned this pull request

Jun 26, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@vdusek vdusek vdusek approved these changes

Assignees

@janbuchar janbuchar

Labels

t-tooling

Issues with this label are in the ownership of the tooling team.

tested

Temporary label used only programatically for some analytics.

Projects

None yet

Milestone

92nd sprint - Tooling team

Development

Successfully merging this pull request may close these issues.

BasicCrawler.export_to should redefine the key and content_type parameters

2 participants

@janbuchar @vdusek