Home Original page

feat: automatic logging setup by janbuchar · Pull Request #229 · apify/crawlee-python

@janbuchar

@janbuchar janbuchar added the t-tooling

Issues with this label are in the ownership of the tooling team.

label

Jun 25, 2024

@janbuchar

janbuchar

send_request=self._prepare_send_request_function(session, proxy_info),
add_requests=result.add_requests,
push_data=self._push_data,
log=self._logger,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vdusek not sure about this - it may be nice to make a new logger with a name like crawlee.request_handler, but that doesn't match any module, so we'd break a convention.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will log request queue / request list otherwise - am I correct? if so, I'd not override it

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more like crawlee.basic_crawler.basic_crawler, depending on your crawler

@janbuchar

vdusek

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀