feat: expose crawler log by vdusek · Pull Request #316 · apify/crawlee-python

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@vdusek

Copy link

Collaborator

@vdusek vdusek commented

Jul 16, 2024

Description

  • feat: expose crawler log

Issues

Testing

  • manually

Checklist

  • Changes are described in the CHANGELOG.md
  • CI passed

@vdusek vdusek requested a review from janbuchar

July 16, 2024 17:23

@github-actions github-actions bot added this to the 94th sprint - Tooling team milestone

Jul 16, 2024

@github-actions github-actions bot added the t-tooling

Issues with this label are in the ownership of the tooling team.

label

Jul 16, 2024
Copy link

Collaborator

@janbuchar janbuchar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tests would be nice though

@github-actions github-actions bot added the tested

Temporary label used only programatically for some analytics.

label

Jul 18, 2024

@vdusek vdusek merged commit ae475fa into master

Jul 18, 2024

@vdusek vdusek deleted the expose-crawler-log branch

July 18, 2024 07:55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janbuchar janbuchar janbuchar approved these changes

Assignees

@vdusek vdusek

Labels

t-tooling

Issues with this label are in the ownership of the tooling team.

tested

Temporary label used only programatically for some analytics.

Projects

None yet

Milestone

94th sprint - Tooling team

Development

Successfully merging this pull request may close these issues.

Expose crawler._logger to public

2 participants

@vdusek @janbuchar