feat: blocking detection for playwright crawler by vdusek · Pull Request #328 · apify/crawlee-python
Navigation Menu
{{ message }}
apify / crawlee-python Public
- Notifications You must be signed in to change notification settings
- Fork 705
Merged
feat: blocking detection for playwright crawler#328
feat: blocking detection for playwright crawler#328
Conversation
Copy link
Collaborator
Description
- Add blocking detection for
PlaywrightCrawler. - Improve documentation of the
PlaywrightCrawlerand related components.
Issues
Testing
- Only manual, until we have Enhance
PlaywrightCrawlertesting with mocked Playwright API #197 ready.
Checklist
- Changes are described in the
CHANGELOG.md - CI passed
vdusek added 2 commits
July 19, 2024 13:15
vdusek
requested a review
from janbuchar
vdusek
self-assigned this
github-actions
bot
added this to the
94th sprint - Tooling team milestone
github-actions
bot
added
the
t-tooling
label
Jul 19, 2024janbuchar reviewed Jul 19, 2024
Comment on lines +16 to +19
| Args: | ||
| page: The Playwright `Page` object. | ||
| response: The Playwright `Response` object. | ||
| enqueue_links: The `PlaywrightCrawler` implementation of the `EnqueueLinksFunction` function. |
Copy link
Collaborator
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this correctly rendered in the documentation?
Copy link
Collaborator Author
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, args in API docs currently do not work - #324.
janbuchar approved these changes Jul 19, 2024
vdusek
merged commit
49ff6e2
into
master
vdusek
deleted the
playwright-blocking
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment